Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GuildChannel#guildId not being patched to undefined #10505

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Sep 14, 2024

Please describe the changes this PR makes and why it should be merged:

Fixes #10495.

guild_id only gets passed to Action#getChannel() if it exists in the payload as key.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Qjuh Qjuh requested a review from a team as a code owner September 14, 2024 10:25
Copy link

vercel bot commented Sep 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2024 10:55am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2024 10:55am

@Qjuh Qjuh requested a review from Syjalo September 14, 2024 10:59
@kodiakhq kodiakhq bot merged commit 2adee06 into discordjs:main Sep 14, 2024
7 checks passed
@Qjuh Qjuh deleted the fix/guildchannel-null-guildid branch September 14, 2024 17:44
monbrey pushed a commit to monbrey/discord.js that referenced this pull request Sep 18, 2024
…js#10505)

* fix: `GuildChannel#guildId` not being patched to `undefined`

* fix: guildId to guild_id check
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
…js#10505)

* fix: `GuildChannel#guildId` not being patched to `undefined`

* fix: guildId to guild_id check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

interaction.channel.guildId undefined after ephemeral reply
5 participants