refactor: builders #10448
Merged
refactor: builders #10448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
github-actions
bot
added
packages:builders
packages:discord.js
packages:collection
packages:voice
packages:ws
packages:proxy
packages:docgen
packages:proxy-container
packages:util
apps:guide
apps:website
packages:ui
packages:brokers
packages:core
packages:formatters
packages:next
packages:create-discord-bot
packages:api-extractor
packages:api-extractor-model
labels
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10448 +/- ##
==========================================
- Coverage 35.48% 35.34% -0.14%
==========================================
Files 228 240 +12
Lines 14308 14612 +304
Branches 1254 1219 -35
==========================================
+ Hits 5077 5165 +88
- Misses 9187 9400 +213
- Partials 44 47 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
didinele
force-pushed
the
impl/builders-v2
branch
from
f4b8bb4
to
57cc3e7
Compare
almeidx
requested changes
Sep 26, 2024
packages/builders/src/components/button/mixins/URLOrCustomIdButtonMixin.ts
Outdated
Show resolved
Hide resolved
didinele
force-pushed
the
impl/builders-v2
branch
from
90a32c2
to
cf08a21
Compare
almeidx
reviewed
Sep 27, 2024
packages/builders/src/components/button/mixins/URLOrCustomIdButtonMixin.ts
Outdated
Show resolved
Hide resolved
didinele
force-pushed
the
impl/builders-v2
branch
from
cf08a21
to
7ccec6c
Compare
almeidx
approved these changes
Sep 27, 2024
vladfrangu
requested changes
Sep 27, 2024
packages/builders/src/interactions/commands/SharedNameAndDescription.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/ChatInputCommandSubcommands.ts
Outdated
Show resolved
Hide resolved
...ders/src/interactions/commands/chatInput/mixins/ApplicationCommandOptionChannelTypesMixin.ts
Outdated
Show resolved
Hide resolved
...ders/src/interactions/commands/chatInput/mixins/ApplicationCommandOptionChannelTypesMixin.ts
Outdated
Show resolved
Hide resolved
...ders/src/interactions/commands/chatInput/mixins/ApplicationCommandOptionChannelTypesMixin.ts
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/integer.ts
Outdated
Show resolved
Hide resolved
didinele
force-pushed
the
impl/builders-v2
branch
from
7ccec6c
to
749e4fa
Compare
almeidx
reviewed
Sep 27, 2024
packages/builders/src/interactions/commands/SharedNameAndDescription.ts
Outdated
Show resolved
Hide resolved
didinele
force-pushed
the
impl/builders-v2
branch
from
749e4fa
to
f099bdf
Compare
vladfrangu
approved these changes
Sep 28, 2024
Syjalo
suggested changes
Sep 28, 2024
Syjalo
suggested changes
Sep 28, 2024
packages/builders/src/components/button/mixins/EmojiOrLabelButtonMixin.ts
Show resolved
Hide resolved
didinele
force-pushed
the
impl/builders-v2
branch
from
f099bdf
to
029cd5d
Compare
iCrawl
approved these changes
Sep 29, 2024
iCrawl
approved these changes
Sep 29, 2024
Syjalo
suggested changes
Sep 30, 2024
packages/builders/src/interactions/commands/chatInput/options/attachment.ts
Show resolved
Hide resolved
didinele
force-pushed
the
impl/builders-v2
branch
2 times, most recently
from
61e4119
to
37aa751
Compare
This was referenced Oct 1, 2024
BREAKING CHANGE: formatters export removed (prev. deprecated) BREAKING CHANGE: `SelectMenuBuilder` and `SelectMenuOptionBuilder` have been removed (prev. deprecated) BREAKING CHANGE: `EmbedBuilder` no longer takes camalCase options BREAKING CHANGE: `ActionRowBuilder` now has specialized `[add/set]X` methods as opposed to the current `[add/set]Components` BREAKING CHANGE: Removed `equals` methods BREAKING CHANGE: Sapphire -> zod for validation BREAKING CHANGE: Removed the ability to pass `null`/`undefined` to clear fields, use `clearX()` instead BREAKING CHANGE: Renamed all "slash command" symbols to instead use "chat input command" BREAKING CHANGE: Removed `ContextMenuCommandBuilder` in favor of `MessageCommandBuilder` and `UserCommandBuilder` BREAKING CHANGE: Removed support for passing the "string key"s of enums BREAKING CHANGE: Removed `Button` class in favor for specialized classes depending on the style BREAKING CHANGE: Removed nested `addX` styled-methods in favor of plural `addXs` Co-authored-by: Vlad Frangu <[email protected]> Co-authored-by: Almeida <[email protected]>
vladfrangu
force-pushed
the
impl/builders-v2
branch
from
37aa751
to
72c28d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Closes #8015
Change list/resolution points:
@discordjs/formattersre-export (deprecated currently)SelectMenuBuilderandSelectMenuOptionBuilderaliases (deprecated currently, left-over from before we had different types of select menus)datafieldEmbedBuilderno longer takes in camalCase optionsEmbedBuildernow has "nested builders" implemented for things like the author and footer.setDMPermissionActionRowBuildernow has specialized[add/set]Xmethods as opposed to the current[add/set]ComponentstoJSON())structuredCloneclearX()methods as opposed to taking previously inconsistentnullorundefinedto clearequalsmethods, if they're needed & desired, we can easily re-implement them (and this time on all classes too)shapeshifttozod, supersedes refactor: use zod in builders #10117BREAKING CHANGE: formatters export removed (prev. deprecated)
BREAKING CHANGE:
SelectMenuBuilderandSelectMenuOptionBuilderhave been removed (prev. deprecated)BREAKING CHANGE:
EmbedBuilderno longer takes camalCase optionsBREAKING CHANGE:
ActionRowBuildernow has specialized[add/set]Xmethods as opposed to the current[add/set]ComponentsBREAKING CHANGE: Removed
equalsmethodsBREAKING CHANGE: Sapphire -> zod for validation
BREAKING CHANGE: Removed the ability to pass
null/undefinedto clear fields, useclearX()insteadBREAKING CHANGE: Renamed all "slash command" symbols to instead use "chat input command"
BREAKING CHANGE: Removed
ContextMenuCommandBuilderin favor ofMessageCommandBuilderandUserCommandBuilderBREAKING CHANGE: Removed support for passing the "string key"s of enums
BREAKING CHANGE: Removed
Buttonclass in favor for specialized classes depending on the styleBREAKING CHANGE: Removed nested
addXstyled-methods in favor of pluraladdXs