-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Action): Ensure all properties on getChannel()
are passed
#10278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
vladfrangu
approved these changes
May 15, 2024
kyranet
approved these changes
May 16, 2024
SpaceEEC
approved these changes
May 16, 2024
This was referenced Jun 24, 2024
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
User-installable applications are in the wild, and this is one problem I have noticed so far, despite not being exactly relevant.
When a command is invoked in a group direct message channel and the channel partial is enabled, discord.js will proceed to create a channel (as direct message channels not initially cached). This is an example payload:
Notice
type
is3
. discord.js results in this channel:type
has been modified to1
! It's aDMChannel
now!The reason this happens is because of the way
getChannel()
works:discord.js/packages/discord.js/src/client/actions/Action.js
Lines 30 to 50 in 35207b0
We are only extracting properties from
data
and sending them off aspayloadData
. This is an example resulting payload:We are losing properties here, most notably,
type
. Merging our overriding properties alongside the original data allows aPartialGroupDMChannel
to be created.Status and versioning classification: