Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make Instance#fetch force true by default, and fix force parameter #6116

Merged
merged 4 commits into from
Jul 17, 2021
Merged

feat: make Instance#fetch force true by default, and fix force parameter #6116

merged 4 commits into from
Jul 17, 2021

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Jul 15, 2021 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Currently, (User|Channel|Message)#fetch ignores the force parameter, always treating it as false. This PR fixes it.

It also sets force to true on all instance fetch methods, after discussion in #library-discussions

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13 milestone Jul 15, 2021
@DTrombett
Copy link
Contributor

DTrombett commented Jul 15, 2021 •
edited
Loading

While you're at it, could you fix the same problem with the other structures, like Channel#fetch()? (If considered related to this ofc).
Structures with this error: User, Channel, Message

@advaith1 advaith1 changed the title fix(User): fetch force parameter fix: #fetch force parameter Jul 15, 2021
@advaith1 advaith1 changed the title fix: #fetch force parameter feat: make Instance#fetch force true by default, and fix force parameter Jul 15, 2021
almeidx
almeidx requested changes Jul 15, 2021
View reviewed changes
src/structures/Channel.js Outdated Show resolved Hide resolved
src/structures/DMChannel.js Outdated Show resolved Hide resolved
src/structures/GuildBan.js Outdated Show resolved Hide resolved
src/structures/GuildMember.js Outdated Show resolved Hide resolved
src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/User.js Outdated Show resolved Hide resolved
@advaith1 @almeidx
fix default in docs
8c86514 
Co-authored-by: Almeida <[email protected]>
@iCrawl iCrawl merged commit 366f3c9 into discordjs:master Jul 17, 2021
@advaith1 advaith1 deleted the fix-user-force-fetch branch July 18, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@memikri memikri memikri approved these changes

@DTrombett DTrombett DTrombett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.
8 participants
@advaith1 @DTrombett @vladfrangu @iCrawl @kyranet @SpaceEEC @almeidx @memikri