Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Typings): Fix BitField toJSON/valueOf return types #5806

Merged
merged 2 commits into from
Jun 11, 2021

Conversation

wasdennnoch
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

In #4879 BitFields were updated to support other value types such as BigInts, however some of the typings weren't updated accordingly.
Reference:

toJSON() {
return typeof this.bitfield === 'number' ? this.bitfield : this.bitfield.toString();
}
valueOf() {
return this.bitfield;
}

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@kyranet kyranet changed the title fix(Typings): Fix BitFied toJSON/valueOf return types fix(Typings): Fix BitField toJSON/valueOf return types Jun 11, 2021
@iCrawl iCrawl merged commit 935f819 into discordjs:master Jun 11, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants