Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ShardingManager): Allow b-Eval/fetchClientValues on a specific shard when not all are ready #5222

Merged
merged 1 commit into from
Jan 24, 2021
Merged

feat(ShardingManager): Allow b-Eval/fetchClientValues on a specific shard when not all are ready #5222

merged 1 commit into from
Jan 24, 2021

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Jan 18, 2021 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

MattIPv4
MattIPv4 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@MattIPv4
Copy link
Contributor

(This also allows fetchClientValues to be run on a specific shard prior to all shards being spawned)

@Skye-31 Skye-31 changed the title feat(ShardingManager): Allow b-Eval on a specific shard when not all are ready feat(ShardingManager): Allow b-Eval/fetchClientValues on a specific shard when not all are ready Jan 18, 2021
@iCrawl iCrawl merged commit 001676c into discordjs:master Jan 24, 2021
@iCrawl iCrawl mentioned this pull request Mar 5, 2021
Closed
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.
6 participants
@Skye-31 @MattIPv4 @vladfrangu @iCrawl @kyranet @almostSouji