broadcastEval throws SHARDING_IN_PROCESS error even though it should execute no matter how many shards are open

[nobu-sh]

broadcastEval throws a SHARDING_IN_PROCESS error when trying to use during shards being spawned however this was not an issue in older versions of the library

shard.js

const { ShardingManager } = require('discord.js')
const constants = require('./constants')

const manager = new ShardingManager('./src/index.js', {
  token: process.env.TOKEN,
  totalShards: constants.totalShards,
})

manager.spawn(process.env.TOTAL_SHARDS, 10000, -1)

index.js

const { Client } = require('discord.js')
const client = new Client()

client.on('ready', () => {
   client.shard.broadcastEval(`
      this.user.setActivity("Bot Starting Up...", { type: "PLAYING" }) 
   `).then().catch()
})

client.login(process.env.TOKEN)

Further details:

• discord.js version: ^12.5.1
• Node.js version: 14.15.4
• Operating system: Windows 10

[iCrawl]

Define:

an issue in older versions of the library

If you upgraded from v11 to v12 breaking changes are to be expected.

[iCrawl]

Ref: #5222

[MattIPv4]

Working around this is relatively easy if you have a need to run broadcastEval on your shards whilst some are spawning -- just iterate over each shard and call broadcastEval with the shard number, catching the error thrown for any shards that are currently being spawned.

I would not consider SHARDING_IN_PROCESS being thrown to be a bug here, you are trying to call broadcastEval which is designed by default to broadcast to all shards, but not all shards are available so you are getting the appropriate error back.

[kyranet]

Closing as it's resolved in the master branch with #5222.