fix(Message): #system non-zero message types are not guaranteed to be system #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaporoxx
reviewed
Dec 12, 2020
vaporoxx
reviewed
Dec 12, 2020
Co-authored-by: Jan <[email protected]>
|
oh yeah, you need to add it to |
vladfrangu
approved these changes
Dec 12, 2020
kyranet
approved these changes
Dec 12, 2020
SpaceEEC
approved these changes
Dec 12, 2020
iCrawl
approved these changes
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of discord/discord-api-docs#2118 not all non-zero message types are system.
Type 19
Replyis the only current type that benefits from this change.Note: the reply type will only be recieved once #4879 is implemented.
This PR also introduces SystemMessageTypes so that future message types can be more easily sorted.
Status
Semantic versioning classification: