Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

feat(RequestManager): support setting global headers in options #70

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Oct 8, 2021

Please describe the changes this PR makes and why it should be merged:

Back on the horse trying to catch up /rest to what exists in the main lib.

This PR ports the logic from

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #70 (601e809) into main (65cb8e2) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   85.84%   85.93%   +0.09%     
==========================================
  Files           8        8              
  Lines        1010     1017       +7     
  Branches      101      101              
==========================================
+ Hits          867      874       +7     
  Misses         42       42              
  Partials      101      101              
Impacted Files Coverage Δ
packages/rest/src/lib/REST.ts 95.58% <100.00%> (+0.12%) ⬆️
packages/rest/src/lib/RequestManager.ts 82.72% <100.00%> (+0.05%) ⬆️
packages/rest/src/lib/utils/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cb8e2...601e809. Read the comment docs.

kyranet
kyranet previously approved these changes Oct 8, 2021
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kyra happy trigger moment

packages/rest/src/lib/REST.ts Outdated Show resolved Hide resolved
@iCrawl iCrawl merged commit d1758c7 into discordjs:main Oct 8, 2021
@ckohen ckohen deleted the custom-headers branch October 8, 2021 22:53
@iCrawl iCrawl added the rest label Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants