-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow activity types #149
base: master
Are you sure you want to change the base?
allow activity types #149
Conversation
It should be noted that the ActivityType enum is discarded in outgoing transport. It is solely for use of incoming messages (e.g. reading friend's activity From the official docs:
|
@afoxie I think you're looking at the wrong docs, if you start from https://discord.com/developers/docs/topics/rpc#setactivity (what is used internally), you land at https://discord.com/developers/docs/topics/gateway#activity-object-activity-types, which doesn't have this restriction. |
Have any of you even checked to see if this PR works? this literally doesn't work. first of all child "activity" fails because [child "type" fails because ["type" must be one of [0, 3]]] second of all even if you input type |
PR doesn't work, but this is an issue that needs to be looked into. |
src/constants.js
Outdated
exports.ActivityTypes = { | ||
PLAYING: 0, | ||
STREAMING: 1, | ||
LISTENING: 2, | ||
WATCHING: 3, | ||
CUSTOM: 4, | ||
COMPETING: 5 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exports.ActivityTypes = { | |
PLAYING: 0, | |
STREAMING: 1, | |
LISTENING: 2, | |
WATCHING: 3, | |
CUSTOM: 4, | |
COMPETING: 5 | |
} | |
exports.ActivityTypes = { | |
PLAYING: 0, | |
WATCHING: 3 | |
} |
Only PLAYING and WATCHING are allowed by RPC. Everything else results in an error.
Just to clarify something: This PR was only meant to provide feature-complete integration according to the API docs (https://discord.com/developers/docs/topics/gateway-events#activity-object-activity-types), assuming in the future the use of these constants would open up to the public. I'm aware it's not working right now (since there is no public access to most of the constants) and I'm willing to close this request if there's no need for it. |
Co-authored-by: advaith <[email protected]>
Activity Types are now supported in discord rpc - see https://x.com/advaithj1/status/1816655583107510517 (Jul 26, 2024) ActivityType typescript definition here: https://github.com/discordjs/discord-api-types/blob/a59f9f002f2fad7cdc6ce8aa9cf04081db2e0da8/payloads/v10/gateway.ts#L251-L276 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
This allows for sending activity types described here.
I also included some handy constants to use.
This fixes #146