add message_author_id to 'Message Reaction Add' Gateway event
#6102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be clarified that this won't be present when reacting to webhook messages |
valdotle
reviewed
May 26, 2023
docs/topics/Gateway_Events.md
Outdated
| | guild_id? | snowflake | ID of the guild | | ||
| | member? | [member](#DOCS_RESOURCES_GUILD/guild-member-object) object | Member who reacted if this happened in a guild | | ||
| | emoji | a partial [emoji](#DOCS_RESOURCES_EMOJI/emoji-object) object | Emoji used to react - [example](#DOCS_RESOURCES_EMOJI/emoji-object-standard-emoji-example) | | ||
| | message_author_id | snowflake | ID of the user that authored the message that was reacted to | |
There was a problem hiding this comment.
Suggested change
| | message_author_id | snowflake | ID of the user that authored the message that was reacted to | | |
| | message_author_id | snowflake | ID of the user who authored the message that was reacted to | |
I'd say, that way the description sounds better...
There was a problem hiding this comment.
I think both "that" and "who" are clear enough so I don't care which one to use, but a bot could also be a message author, and "who" isn't exactly correct for bots AFAIK.
There was a problem hiding this comment.
I think it's more about having 2 "that" in the same sentence. correct but maybe a bit weird?
There was a problem hiding this comment.
ok I guess who sounds better
There was a problem hiding this comment.
Alternatively, you could replace the second "that" with "which"...
DonovanDMC
added a commit
to OceanicJS/Oceanic
that referenced
this pull request
May 27, 2023
shaydewael
approved these changes
Jul 13, 2023
6 tasks
Nihlus
added a commit
to Remora/Remora.Discord
that referenced
this pull request
Jul 14, 2023
HTGAzureX1212
pushed a commit
to twilight-rs/twilight
that referenced
this pull request
Jul 16, 2023
sebm253
pushed a commit
to disgoorg/disgo
that referenced
this pull request
Jul 16, 2023
This was referenced Jul 18, 2023
lukellmann
added a commit
to kordlib/kord
that referenced
this pull request
Sep 18, 2023
lukellmann
added a commit
to kordlib/kord
that referenced
this pull request
Sep 18, 2023
shaydewael
pushed a commit
to Jupith/discord-api-docs
that referenced
this pull request
May 14, 2024
…ord#6102) * add `message_author_id` to Message Reaction Add * better description * use 'who' instead of 'that' * use 'which' instead of 'that'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.