-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document role subscriptions #5724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning
Nerd 🤓
But more seriously, I really like the wording and formatting you used, it's in a way an idiot could understand. Really thorough too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just left one comment, let's make a quick change for that and get this merged
docs/resources/Guild.md
Outdated
| INVITES_DISABLED | guild has paused invites, preventing new users from joining | | ||
| INVITE_SPLASH | guild has access to set an invite splash background | | ||
| MEMBER_VERIFICATION_GATE_ENABLED | guild has enabled [Membership Screening](#DOCS_RESOURCES_GUILD/membership-screening-object) | | ||
| MONETIZATION_ENABLED | guild has enabled monetization | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove MONETIZATION_ENABLED
since it's been replaced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done; are there any other features I should add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it all looks good. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll get this merged soon
* 30056, 50144, 50145: discord/discord-api-docs#5724 * 30058: discord/discord-api-docs@383f039 * 50067: discord/discord-api-docs#5626 * 40062: discord/discord-api-docs#5574 * 50091: discord/discord-api-docs#5746
* rename GuildFeature.CreatorMonetizableProvision to GuildFeature.CreatorMonetizableProvisional * deprecate GuildFeature.MonetizationEnabled, see discord/discord-api-docs#5724 (comment) * add @SerialName for DiscordRoleTags.botId * add RoleTags.isLinkedRole * fix DiscordMessage.roleSubscriptionData nullability * fix KDocs see discord/discord-api-docs#5724 and discord/discord-api-docs#5828
* rename GuildFeature.CreatorMonetizableProvision to GuildFeature.CreatorMonetizableProvisional * deprecate GuildFeature.MonetizationEnabled, see discord/discord-api-docs#5724 (comment) * add @SerialName for DiscordRoleTags.botId * add RoleTags.isLinkedRole * fix DiscordMessage.roleSubscriptionData nullability * fix KDocs see discord/discord-api-docs#5724 and discord/discord-api-docs#5828 Co-authored-by: NoComment <[email protected]>
* Document role subscriptions * remove MONETIZATION_ENABLED guild feature
Bots can't access the subscription-related endpoints but I documented the role tags, premium emoji stuff, integration type, message type, and publicly available guild features (not the testing guild features). I didn't document the subscription listing stuff in /discovery/:slug since that endpoint is not documented yet (requires #1762).
resolves #5711