Postgresql #3
Open
Postgresql #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoBektesevic
force-pushed
the
postgresql
branch
from
1c17165
to
4db4f4a
Compare
Configuration class that maps YAML dictionaries to instance attributes. Should be flexible enough when in the future we transition to PostgreSQL DBMS. Removed security key logic out of settings.py.
Add equality comparison operator for Config. Make a test directory for trails app, add example config files. Write tests.
Add a more explicitly named class for database configs. Rename config file to secrets since that's the intended use. Add the bit of functionality that isolates the desired keys from the entire yaml to simplify use. Update tests.
Add secrets resolution via AWS Secrets manager for simple and multi-keyed secrets. Add tests. Add documentation.
mrawls
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #2
Transitioned and tested functionality on PostgreSQL.