Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to numpy 2.0 #754

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Upgrade to numpy 2.0 #754

merged 1 commit into from
Dec 16, 2024

Conversation

jeremykubica
Copy link
Contributor

@jeremykubica jeremykubica commented Dec 16, 2024

Upgrade the eigen and pybind11 submodules (using git submodule update --remote) and upgrade to numpy >2.0. A lot of minimum versions need to change to ensure all the dependencies (direct and indirect) are compatible with numpy 2.0.

Closes #658

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems reasonable. I checked the CI logs because I would assume that any trouble would show up there - everything looked fine there. Nice job.

@jeremykubica jeremykubica merged commit c14abe7 into main Dec 16, 2024
2 checks passed
@jeremykubica jeremykubica deleted the upgrade_numpy branch December 16, 2024 18:51
jeremykubica added a commit that referenced this pull request Dec 17, 2024
This reverts commit c14abe7, reversing
changes made to 39f025b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support numpy v2.0
2 participants