Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the location information to the WorkUnit #738

Closed
wants to merge 1 commit into from

Conversation

jeremykubica
Copy link
Contributor

This is a step in better propagation of provenance information. Pass information from the standardizer's location field to the WorkUnit. This might not provide perfect information about the data source. For example in memory fits files will just produce ":memory:".

@DinoBektesevic
Copy link
Member

This is probably not the right way to do it. I would use toBinTableHDU and append it to the HDUList of a WorkUnit. If you want to add an imagecollection property to the WorkUnit there's a fromBinTableHDU on an imagecollection. As you note location is not a unique init key required by Standardizers.

This was blocked for a bit by messy metadata tracking within WorkUnit. Some of this was cleaned up so I guess we can do it. It can't hurt to add it, but I've seen WU with 700+ HDUs. It's probs more worth to clean that up in comparison, mostly because we don't keep WUs around during/after processing due to their size.

@jeremykubica
Copy link
Contributor Author

Closing since Dino indicates there is a better way to do this.

@jeremykubica jeremykubica deleted the pass_location branch November 15, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants