Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper functions for evaluation #727

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Add helper functions for evaluation #727

merged 3 commits into from
Oct 25, 2024

Conversation

jeremykubica
Copy link
Contributor

@jeremykubica jeremykubica commented Oct 25, 2024 •
edited
Loading

Add a bunch of functions based on @wilsonbb evaluation notebooks. These include

  • A function to do a linear fit from lists of pixel locations and times: fit_trajectory_from_pixels
  • A function to compute the mean squared error from a given trajectory and lists of pixel locations: evaluate_trajectory_mse
  • A function within WorkUnit that will convert (RA, dec) positions into pixel coordinates: get_pixel_coordinates

Co-authored-by: Wilson Beebe [email protected]

@jeremykubica jeremykubica requested a review from wilsonbb October 25, 2024 15:35
wilsonbb
wilsonbb requested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a typo!

src/kbmod/work_unit.py Outdated Show resolved Hide resolved
@wilsonbb wilsonbb self-requested a review October 25, 2024 17:54
@jeremykubica jeremykubica merged commit b1ae7ee into main Oct 25, 2024
2 checks passed
@jeremykubica jeremykubica deleted the coord_to_pixel branch October 25, 2024 17:56
@jeremykubica jeremykubica mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonbb wilsonbb wilsonbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremykubica @wilsonbb