Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the (unused) valid bit from trajectories. #707

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

jeremykubica
Copy link
Contributor

@jeremykubica jeremykubica commented Sep 16, 2024

The valid bit was meant to be a way to indicate that something is filtered on the GPU, but we use num_obs or likelihood instead. We can drop this bit to save both space in the results and time in filtering without changing behavior.

Also does a few smaller cleanups:

  • Adds some more logging and timing
  • Removes unused sorting and filtering code from the TrajectoryList.

@jeremykubica jeremykubica merged commit e01f775 into main Sep 16, 2024
2 checks passed
@jeremykubica jeremykubica deleted the small_optimizations branch September 16, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants