Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrongly oriented BBox in IC. #694

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

DinoBektesevic
Copy link
Member

@DinoBektesevic DinoBektesevic commented Sep 4, 2024

This, hopefully, finally correctly orients the BBox in the image collections.
PR also:

  1. Fixes the default astropy bbox calculation method
  2. Flips the wrongly mirrored bottom left and bottom right corners
  3. Flips the mirrored naxis keywords in between the SkyWcs and Astropy's WCS methods
  4. Makes a dictionary out of the PropertyList object returned by the stack so that standardizer can be re-used without exhausting the generator values.
  5. Adds more explicit documentation about what corner is what

Sorry about the mess.

Copy link
Collaborator

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DinoBektesevic DinoBektesevic merged commit 2869f17 into main Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants