Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a table-based result data structure #549
Create a table-based result data structure #549
Changes from 7 commits
bdc2968
f494eaa
032e1b9
673bd7e
c444c5b
0776084
1849512
2a46779
d6ec08f
32659f3
f8938f5
ba7dc44
c77b95c
fd3fe77
26b6755
933cf9e
5fa1334
72ed621
5fe9e62
1b964d4
04e8926
deb3c9f
9e790cf
84484cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not always very clear what's
index_valid
,inds
,valid_indices
and they keep shifting names but I have no better naming suggestions though.add_psi_phi
callsupdate_lh
callsupdate_trj_from_psi_phi
, it's all for loops and can be replaced by (if it's ok that there are no jagged arrays in the table like we talked about) with this:and this is all vectorized so pretty fast and most of the time in-place so no extra memory allocations. You seemed to be somewhat concerned about that, judging by the comments.