Add some helpers for working with result tables #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
wilsonbb
approved these changes
Apr 5, 2024
Comment on lines
+904
to
+905
| self.filter_results(table["index"], "Table filtered") | ||
| table["index"] = range(len(table)) |
There was a problem hiding this comment.
Just a comment for when we actually address #535 : I'm presuming we want to actually set an astropy.table index, but curious if there are any specific reasons why we were choosing not to do so (for example extra performance cost not worth it for hopefully small ResultLists)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix to enable more dynamic exploration until we address #535. It adds an index column to the table resulting from
ResultList.to_table()which can be used to map back to the result's index in the originalResultList. It also adds a helper function to keep the two in sync (which is a bit of a hack and should be removed by a more proper approach like #535).Adds examples of how to use the new functionality to the results notebook.