Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add correct_parallax #529

Merged
merged 3 commits into from
Mar 22, 2024
Merged

add correct_parallax #529

merged 3 commits into from
Mar 22, 2024

Conversation

maxwest-uw
Copy link
Collaborator

adds the parallax correction function as a utility and adds a test (values described here.

Copy link
Member

@DinoBektesevic DinoBektesevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add

References
----------

.. [1] `Jupyter Notebook <https://github.com/DinoBektesevic/region_search_example/blob/main/02_accounting_parallax.ipynb>`_

to the function docstring. Make black ignore the line if it mangles it but it shouldn't. We'll update the link to an documentation page in the repo itself (maybe, if we write it).

@maxwest-uw maxwest-uw merged commit 26e5567 into main Mar 22, 2024
2 checks passed
@maxwest-uw maxwest-uw deleted the reproject_utils branch March 22, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants