Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the fake data creators #467

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Reorganize the fake data creators #467

merged 1 commit into from
Feb 12, 2024

Conversation

jeremykubica
Copy link
Contributor

Put the all the fake data creation helpers in one directory. Also cleans up some more tests (using FakeDataSet and make_trajectory) that were not included in #466.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I left 2 questions about some maybe inconsistencies, but I'm not well enough versed to know for sure.

@jeremykubica jeremykubica merged commit 74d56f2 into main Feb 12, 2024
2 checks passed
@jeremykubica jeremykubica deleted the fake_data_reorg branch February 12, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants