Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filtering done in
analysis_utils.py
only filters out results with < 3 observations (after sigmaG clipping) regardless of the number of observations provided in the config. This tightens the threshold to match the given number of observations. This changes the diff test by dropping out results that had too few observations.This also combines the two filtering steps for efficiency, so we are only looping through the results once (instead of twice).
Adds two new filters:
CombinedStatsFilter
filter combines likelihood bounds and minimum number of observations. This is for efficiencyDurationFilter
filters based on the time duration of the track. This is a potential to explore in the future.Finally the PR removes the custom
_make_trajectory
helper function in one of the tests and replaces it with themake_trajectory
function fromtrajectory_utils.py
.