Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup LayeredImage PSF usage #345

Merged
merged 5 commits into from
Sep 24, 2023
Merged

Cleanup LayeredImage PSF usage #345

merged 5 commits into from
Sep 24, 2023

Conversation

jeremykubica
Copy link
Contributor

This is a cleanup PR aimed at simplifying how LayeredImage uses the PSF:

  • Move add_object from LayeredImage to fake_data_creator.py. This function is only used in testing to create fake data and is a better fit to fake_data_creator.py. This also removes one of LayeredImage's use of PSFs.
  • Add no-op PSF constructor for testing. This can also be used to make PSFs effectively optional in LayeredImage by passing in a no-op.
  • Add a convolve function to LayeredImage that takes an external PSF (with the goal of making PSFs in LayeredImage optional).
  • Remove psf_sq as a class variable for LayeredImage. Recomputing it is not expensive compared to the subsequent convolve operations.

@jeremykubica jeremykubica merged commit 87fd249 into main Sep 24, 2023
1 check passed
DinoBektesevic added a commit that referenced this pull request Sep 25, 2023
Rebasing after #345 left some old references, to renamed methods,
that I must have missed to correct in the rebase.

Added documentation entry for the new methods.
Removed the documentation entries for methods removed in #345.
DinoBektesevic added a commit that referenced this pull request Sep 25, 2023
Rebasing after #345 left some old references, to renamed methods,
that I must have missed to correct in the rebase.

Added documentation entry for the new methods.
Removed the documentation entries for methods removed in #345.
DinoBektesevic added a commit that referenced this pull request Sep 25, 2023
Rebasing after #345 left some old references, to renamed methods,
that I must have missed to correct in the rebase.

Added documentation entry for the new methods.
Removed the documentation entries for methods removed in #345.
DinoBektesevic added a commit that referenced this pull request Sep 25, 2023
Rebasing after #345 left some old references, to renamed methods,
that I must have missed to correct in the rebase.

Added documentation entry for the new methods.
Removed the documentation entries for methods removed in #345.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants