Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup PR aimed at simplifying how
LayeredImage
uses the PSF:add_object
fromLayeredImage
tofake_data_creator.py
. This function is only used in testing to create fake data and is a better fit tofake_data_creator.py
. This also removes one ofLayeredImage
's use of PSFs.LayeredImage
by passing in a no-op.LayeredImage
that takes an external PSF (with the goal of making PSFs inLayeredImage
optional).psf_sq
as a class variable forLayeredImage
. Recomputing it is not expensive compared to the subsequent convolve operations.