Create new stamp plotting class #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwest-uw
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
looks good, the only thing that seems kind of weird to me is that you have imshow being called in plot_single_stamp, even when it's being called multiple times like in plot_stamps (which in my mind should create multiple different plot images) but mpl has a lot of magic going on under the hood and it seems like it works fine in the notebook so 🤷♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in breaking up the functionality in
create_stamps.py. This PR creates a newResultsVisualizerclass and updateskbmod_analysis_demo.ipynbto use that instead ofcreate_stamps.py.We also move
create_stamps.pyback into the analysis directory to keep the top level directory cleaner.