add Uukanshu (www & tw subdomains) #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2024 21:54
…simplified cn) uukanshu_sj: rename class & make format_text a staticmethod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2263
There was already an existing Parser but that was for a very different looking
sj.subdomain so I renamed the file & class whilst making use of its existing custom text filter.I split up the commits in hope that it wouldn't destroy the existing git history on the previous sj subdomain crawler but that seems to not have worked when looking at the changelist of this PR... -> reviewing this PR in the per commit view would make the most sense.
The www subdomain returns simplified CN in GBK encoding, the tw subdomain returns traditional CN in utf-8 encoding.
I tried to explain in the code comments wherever it might be confusing.
Tested with a pretty large novel
https://www.uukanshu.net/b/86005/#gsc.tab=0which has over 6k chapters and is split into 9 novels. Tested both tw and www subdomains, output matches website content.