Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Syosetu and Fanstrans #2243

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Fix Syosetu and Fanstrans #2243

merged 7 commits into from
Feb 12, 2024

Conversation

NilanEkanayake
Copy link
Contributor

@NilanEkanayake NilanEkanayake commented Jan 26, 2024

Syosetu has added pages, so I added a check to see if the source has multiple pages, and if so, iterate through them and scrape as normal. (Was a bit of a rush job, technically works but probably has issues)

Also fixed fanstrans on the side.

I locally fixed a couple of other sources too, might commit them later once I've checked them over

@NilanEkanayake
Copy link
Contributor Author

NilanEkanayake commented Jan 26, 2024

I added
def initialize(self) -> None: self.init_executor(2)
But it might not be necessary for most. I was downloading a few extremely long (~600 chapter) series, and Syosetu rate limited me.

@dipu-bd
Copy link
Owner

dipu-bd commented Feb 9, 2024

@NilanEkanayake I have made some quick changes in syosetu. can you please confirm if the changes are okay?

Copy link
Contributor Author

@NilanEkanayake NilanEkanayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed duplicate self.novel_url
Tested and verified working!

@dipu-bd dipu-bd merged commit 6eac1c0 into dipu-bd:dev Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants