add webfic multilingual source #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds https://www.webfic.com as a source as requested in #2235
Closes #2235
The site hosts novels in multiple languages, though the site itself defaults to english content if the novel doesn't have the language requested.
I tested downloading EN & ES novels, worked without issue.
I also tested searching which uses the site's built-in search function and that also works whilst only returning the english links to all novels found.
One thing to note is that this site is somewhat similar to webnovels in that they paywall most of their content, so the downloader here only downloads the free chapters and also takes that into consideration when showing the user how many chapters a book has (except via search results it shows the acutal total).
So for some books it's more like 60/400 chapters that can actually be downloaded but there's no login either, just the app they want the user to use, so doesn't seem like much can be done there.
-> Should this PR even be merged because of the site's paywall on most content?