Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 14 update planned? #107

Closed
SolidOctoEnigma opened this issue Nov 17, 2022 · 10 comments
Closed

Angular 14 update planned? #107

SolidOctoEnigma opened this issue Nov 17, 2022 · 10 comments

Comments

@SolidOctoEnigma
Copy link

Is Angular 14 update planned, in progress or there is not plan for it yet?

@diprokon
Copy link
Owner

@SolidOctoEnigma is there any issues to use this lib with angular 14/15? Does it require any update?

@Moik
Copy link

Moik commented Nov 29, 2022

@diprokon After updating the app to Angular 15 we are getting the error Cannot read properties of undefined (reading '_switchDataSource'). Also paginator property in TableVirtualScrollDataSource has incompatible type with Material paginator

@diprokon
Copy link
Owner

Ok, thanks for reporting
I will check soon

@harry-kalligeros
Copy link

Any progress on this ?

@motabass
Copy link

motabass commented Dec 19, 2022

The error seems to come from the angular-material 15 update. Angular 15 works for me. But with latest angular material 15.0.3 i also get the error

btw.: I*m still using MatLegacyTableModule instead of the new MDC variant.

@motabass
Copy link

I made a simple workaround by using #virtualScrollTable istead of the class name for referencing the mat-table. Maybe that helps?

#110

@diprokon
Copy link
Owner

After my investigation, there is no issues with Angular 15 or Angular Material 15. Everything works as before

On the other hand, there described issues presented, if "Legacy" table is used (MatLegacyTableModule). Fix for it will be in the next release (in couple days)

@TobiDimmel
Copy link

@diprokon Have your tried the example with sticky header? It doesn't work with the new MDC-based MatTable since the CSS-classes have changed.

I did a basic update process with the Angular CLI for the repository and added a fix for the sticky header problem (see /TobiDimmel/ng-table-virtual-scroll/tree/angular-v15).
I can make a PR if you want.

One thought to MatLegacyTableModule: maybe a proper solution is to also provide a legacy module to align it with the Angular Material approach.

@danielfnz
Copy link

Any progress on this ?

@jb-oahmed
Copy link

I'm still seeing this issue with TypeError: Cannot read properties of undefined (reading '_switchDataSource') at TableItemSizeDirective.ngAfterContentInit (ng-table-virtual-scroll.mjs:251:50).
I'm using Angular version 16 with the MatLegacyTableModule. Is there a planned fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants