fix: pop-up definition overlaps header #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/styles/overrides.scss
Outdated
| @@ -65,7 +65,7 @@ | |||
| } | |||
|
|
|||
| .pc-navigation { | |||
| z-index: 101; | |||
| z-index: 5000; | |||
There was a problem hiding this comment.
why is it 5000 and not 102 for examle ? what is z-index of pop-up ?
There was a problem hiding this comment.
Pop-ups have a z-index: 1000, and for the header I set 5000, because the header should be above all the elements on the page. In addition, an element may appear that should be above the pop-up, but under the header. It can have a z-index: 1001, 1002, etc
There was a problem hiding this comment.
It is always better to choose the smallest number to the required number, than to increase it by a random amount, as this can very quickly lead to too large numbers
There was a problem hiding this comment.
Okay, I get it. Can I use the value 1050? To have a stock of z-index values
JeikZim
added a commit
to diplodoc-platform/transform
that referenced
this pull request
Jul 8, 2024
The pop-up of the terms overlapped the header. Previously, changes were made to @diplodoc/client to solve the problem, with ref: diplodoc-platform/client#51 The changes caused new bug and it was decided to fix the initial bug in another way by changing the z-index of the terms themselves.
JeikZim
added a commit
to diplodoc-platform/transform
that referenced
this pull request
Jul 8, 2024
The pop-up of the terms overlapped the header. Previously, changes were made to @diplodoc/client to solve the problem, with ref: diplodoc-platform/client#51 The changes caused new bug and it was decided to fix the initial bug in another way by changing the z-index of the terms themselves.
JeikZim
pushed a commit
that referenced
this pull request
Sep 20, 2024
fix: pop-up definition overlaps header (#51) --------- Co-authored-by: Ruslan Bagautdinov <[email protected]>
JeikZim
added a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pop-up definition overlaps header