Feature: Add calling code and currency code #25
Conversation
…ode for all current countries avaries in the country data returned
| @@ -17,6 +17,8 @@ class CreateCountryStateCityTable extends Migration | |||
| Schema::create('countries', function (Blueprint $table) { | |||
| $table->bigIncrements('id'); | |||
| $table->string('name',255); | |||
| $table->string('currency_code'); | |||
There was a problem hiding this comment.
add string length $table->string('currency_code',255);
There was a problem hiding this comment.
Thank you @dipeshsukhia,
I will make the change and request a new review.
| @@ -17,6 +17,8 @@ class CreateCountryStateCityTable extends Migration | |||
| Schema::create('countries', function (Blueprint $table) { | |||
| $table->bigIncrements('id'); | |||
| $table->string('name',255); | |||
| $table->string('currency_code'); | |||
| $table->string('calling_code'); | |||
There was a problem hiding this comment.
add string length $table->string('calling_code',255);
There was a problem hiding this comment.
some countries have multiple calling_code like US
How do you handle this?
There was a problem hiding this comment.
For countries with multiple calling_code, the field includes the calling codes separated with commas
There was a problem hiding this comment.
I think comma separation is not a good idea, especially in laravel you can use array cast instead of comma-separated
| @@ -5,3 +5,7 @@ All notable changes to `laravel-country-state-city-data` will be documented in t | |||
| ## 2.0.0 - 2021-05-12 | |||
|
|
|||
| - "Integrity constraint violation: 1062 Duplicate entry" Issue fixed | |||
There was a problem hiding this comment.
add ISO code with 2 digit and 3 digit
There was a problem hiding this comment.
I don't understand this part, please elaborate.
There was a problem hiding this comment.
for example for India, the ISO code is in 2 char IN and 3 char IND for the US in 2 char US and for 3 char USA
you can check Wikipedia link
There was a problem hiding this comment.
Alright, I will look into that. Thanks.
| @@ -17,6 +17,8 @@ class CreateCountryStateCityTable extends Migration | |||
| Schema::create('countries', function (Blueprint $table) { | |||
| $table->bigIncrements('id'); | |||
There was a problem hiding this comment.
also, add the Country ISO code with 2 digit and 3 digit
| @@ -17,6 +17,8 @@ class CreateCountryStateCityTable extends Migration | |||
| Schema::create('countries', function (Blueprint $table) { | |||
| $table->bigIncrements('id'); | |||
| $table->string('name',255); | |||
| $table->string('currency_code'); | |||
| $table->string('calling_code'); | |||
There was a problem hiding this comment.
some countries have multiple calling_code like US
How do you handle this?
|
pull request not as per requriment |
Description
This pull request adds the calling code and currency code for all countries in the countries table.
Related Issue
#24
How Has This Been Tested?
I have tested these changes by installing the package on an existing Laravel application and successfully created the tables that reflect the changes. I tested in both a development environment and a production-like environment to ensure that these updates do not introduce any issues.
Screenshots (if appropriate):
Types of changes
Checklist: