Migrate RecyclerRefreshLayout and sample app to AndroidX #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise minSdkVersion to 14 (for AndroidX) Update buildToolsVersion to latest v28
Flag AndroidX is in use, but no need for jetifier since there are no external dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a conservative migration from Support Library v25 to AndroidX.
The last version of the Android Support Library was v28. It has been deprecated for some time now, and superseded by AndroidX since it became stable in September 2018. Most open source projects have long migrated to AndroidX, but not
RecyclerRefreshLayout. This PR changes that.Migrating to AndroidX also removes the need for
RecyclerRefreshLayoutto be 'jetified', which is the compile-time migration of support-library-dependent libraries to equivalent AndroidX packages.The migration is 'conservative' in the sense that it attempts to only migrate the dependencies and imports to AndroidX, without introducing any other project/code changes. I.e. the Android gradle build tools and gradle wrapper versions remain unchanged. However, some changes are unavoidable. The main one being:
RecyclerRefreshLayoutdepends on.