Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples embedded in spec #163

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Update examples embedded in spec #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion draft/examples/valid/highered-course-part.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
{
"id": "https://orcid.org/0000-0002-3064-147X",
"type": "Person",
"name": "Jens Lechtenbörger"
"name": "Jens Lechtenbörger",
"honorificPrefix": "Dr."
}
],
"description": "A presentation on virtual memory in a course on Operating Systems (following the book Operating Systems and Middleware: Supporting Controlled Interaction by Max Hailperin). Learning objectives: Explain mechanisms and uses for virtual memory (including principle of locality and page fault handling as well as access of data on disk); Explain and perform address translation with page tables",
Expand All @@ -35,6 +36,11 @@
"Computer Science",
"Virtual Memory"
],
"isAccessibleForFree": true,
"conditionsOfAccess": {
"id": "http://w3id.org/kim/conditionsOfAccess/no_login",
"type": "Concept"
},
"license": {
"id": "https://creativecommons.org/licenses/by-sa/4.0/"
},
Expand Down
21 changes: 19 additions & 2 deletions draft/examples/valid/highered-course.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
{
"id": "https://orcid.org/0000-0002-3064-147X",
"type": "Person",
"name": "Jens Lechtenbörger"
"name": "Jens Lechtenbörger",
"honorificPrefix": "Dr."
}
],
"description": "A course on Operating Systems (following the book Operating Systems and Middleware: Supporting Controlled Interaction by Max Hailperin) as part of the module Computer Structures and Operating Systems for 4th-term students in the Bachelor program in Information Systems at the University of Münster, Germany.",
Expand All @@ -36,10 +37,17 @@
"Operation Systems",
"Computer Structures"
],
"isAccessibleForFree": true,
"conditionsOfAccess": {
"id": "http://w3id.org/kim/conditionsOfAccess/no_login",
"type": "Concept"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum ist hier type mit angegeben, bei educationalLevel aber nicht?

Ist beides korrekt, da type bei beiden Attributen angegeben werden KANN.
(trifft auch auch highered-course-part.json zu.

Frage mich, ob das eher verwirrt, wenn in den Beispielen mal so oder so mit optionalen Werten umgegangen wird oder die Beispiele möglichst vollständig sein sollten

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich würde das auch ohne type machen. Habe das auch im OERSI ohne type umgesetzt.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In der genannten Datei steht "type": [ "Concept" ] auch bei about und audience.

Da es im Schema explizit genannt wird, aber nicht required ist, finde ich es schon sinnvoll, wenn es in einigen – aber eben nicht allen – Beispielen auftaucht. Wenn, dann sollten wir das auch komplett aus dem Schema tilgen, womit ich d'accord wäre. Die genannten Informationen finden sich ja ohnehin im RDF, wenn die URI dereferenziert wird. Ich schlage vor, das hier erstmal zu mergen und die Frage in einem gesonderten Ticket zu diskutieren.

},
"license": {
"id": "https://creativecommons.org/licenses/by-sa/4.0/"
},
"inLanguage": [ "en" ],
"inLanguage": [
"en"
],
"audience": [
{
"id": "http://purl.org/dcx/lrmi-vocabs/educationalAudienceRole/student",
Expand All @@ -52,6 +60,15 @@
}
}
],
"educationalLevel": [
{
"id": "https://w3id.org/kim/educationalLevel/level_06",
"prefLabel": {
"de": "Bachelor oder äquivalent",
"en": "Bachelor or equivalent"
}
}
],
"hasPart": [
{
"id": "https://oer.gitlab.io/OS/Operating-Systems-JiTT.html",
Expand Down
4 changes: 3 additions & 1 deletion draft/examples/valid/highered-figure.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@
{
"id": "https://orcid.org/0000-0002-3064-147X",
"type": "Person",
"name": "Jens Lechtenbörger"
"name": "Jens Lechtenbörger",
"honorificPrefix": "Dr."
}
],
"isAccessibleForFree": true,
"license": {
"id": "https://creativecommons.org/licenses/by-sa/4.0/"
},
Expand Down