support -html flag to render output as HTML
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue #69 to support HTML output. This also... - updates the README usage docs - validates that multiple, conflicting format flags are not provided - fixes a bug in the tests to properly validate expected tf-summarize errors Signed-off-by: Mike Ball <[email protected]>
Previously, the tf-summarize tests did not exercise the tool's ability to summarize plan outputs. This fixes that!
By adding a code comment in association with all Make targets, `make help` now documents all targets: ``` $ make help build build the binary example generate example Terraform plan help prints help (only for tasks with comment) i build and install to /usr/local/bin/ install build and install to /usr/local/bin/ lint lint source code test go test ```
This makes the HTML output a bit more consistent with output elsewhere.
This protects against false positives running the tests.
mdb
commented
Mar 2, 2024
mdb
commented
Mar 2, 2024
mdb
commented
Mar 2, 2024
mdb
commented
Mar 2, 2024
mdb
commented
Mar 2, 2024
mdb
commented
Mar 2, 2024
|
👋 Hi @dineshba - I'm curious to hear your thoughts about this PR! |
dineshba
approved these changes
Mar 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #69 to support HTML output.
This also...
tf-summarizetf-summarizetests to exercise the tool's ability to summarize changes to outputs (as well as resources)make helpto output documentation for all Makefile targets-countflag, protecting against false positives ingo testrunsSeed plant for the future: Ultimately, it might be preferable to support a single
-format="json|md|html|table"flag, though I was hesitant to do so in this PR and breaktf-summarize's existing usage in a non-backwards-compatible fashion.