-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added public reposition method and escCloseAll option #8
Conversation
… popup should be closed after pressing esc
I really like the reposition option 👍 |
I like the reposition option too |
Added in v. 0.10.0 (https://github.com/dinbror/bpopup#v-0100-07-22-2014) |
Just wanted to give a heads up on the reposition function. Think there are also some hardcoded values in there as well. Update |
Hey pavdro. You're right. Didn't test against that use case. Will have a fix in the next release. |
Nice 1! |
Actually. |
fixed in v. 0.11.0 |
I've added a public reposition method to allow manual repositioning of the popup after the contents have been changed.
I've also added the escCloseAll option to control if all open or only the topmost popup should be closed, default true.
Regards,
Martin