-
Notifications
You must be signed in to change notification settings - Fork 320
Implement fallback option in case attribute returns empty value #348
Conversation
Would be nice if this is added in! Solves a problem when some fields are translated and some are not and you end up with the website missing texts! |
I like the idea. We still need to update the docs, the configuration and write the tests in order to merge this. |
@k-zakhariy it will be superb if you have time to amend the docs, configuration and tests for this pull request to be accepted by dimsav. |
will push changes soon |
Any updates on this ? |
Thanks a lot for your work. Will try to review this week. |
@k-zakhariy @unitedworx I was thinking to leave out the per-model config. Do you guys have a use case in mind where you plan to have different per model configuration? |
@dimsav I didn't use this ability in my project, for me its easy to declare options in config file. |
i will surely follow a project wide route, if you start having models behaving differently it might be confusing down the line. |
True, that's why I removed the per model config. |
With this option we can have ability to get fallback value from fallback language in case
target language exists but attribute value is empty