This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Delete tests restored #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason you deleted these lines from the tests? I have trouble making this test passing as well. |
|
I didn't understand why test fails, I moved these lines in a new test and it passes. |
|
I found why the test fails. $country->forceDelete() is not removing the row from the database. Weird. |
|
It seems to be a laravel bug. If a model is soft deleted and you apply a forceDelete to it, it won't get removed from the database. I will open an issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests failed because of that SQLite doesn't support foreign keys without PRAGMA foreign_keys = ON
I had to separate tests on softdeletes, I don't know why it failed without that.