Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUI Languages #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add GUI Languages #68

wants to merge 2 commits into from

Conversation

MasQchips
Copy link
Contributor

  • Fixed Icons size extras
  • Small updates language
  • Small improvements
  • Working on language download
  • Working in boot image
  • Working on Message Box

@dimok789
Copy link
Owner

dimok789 commented May 3, 2016

Ah crap. I wanted to actually merge this after a few questions back and now I made conflicts. Sorry about that.
Can you resolve them please?

Ok here are some questions I have:
Were these two functions really necessary?
void setImageSelect(GuiImage* i);
void setImageSelectOver(GuiImage* i);
Don't we have a state that is very similar to this. I dont remember anymore. I would have to take a look at it at some point.

Another point I dont understand yet is what is it with this hard coded number here in SettingsMenu.cpp:
for(u32 n = 0; n < settingsCategories[i].descriptions.size() && n <=5; n++)

The most things look good though and I am ok with merging it all.

@MasQchips
Copy link
Contributor Author

Ah, ok when you have a little time.

about these two functions
setImageSelect void (* GuiImage i);
setImageSelectOver void (* GuiImage i);

"Settings [i] .settingButton-> setIconOver (settings [i] .settingImageSelected);"

"SetIconOver (GuiImage * i)" was occupied by the selection button, the changes are to add icons to the button, but setImageSelect is not being used now I have set for future use. Maybe if I should change "setImageSelectOver" by "setImageSelect" more correct

for (u32 n = 0; n <settingsCategories [i] .descriptions.size (); n ++) already corrected. The result of many hours on the computer trying to get my head assimilates your code. excellent work certainly very good for people like me can learn.

anyway this is just a sample to see if my work is on track, try to make it more like your work and be easy to understand, once finished with the option language can download if you want to add.

@dimok789
Copy link
Owner

dimok789 commented May 4, 2016

Seems to still have some kind of conflicts. You want me to fix those or will you do it?

@djskual
Copy link

djskual commented May 23, 2016

think i've fixed conflicts
here a link to the projects:
https://drive.google.com/file/d/0B6h8xuTOOS2ZbmFVQ254N3lmd0k/view?usp=sharing

@bijita1
Copy link

bijita1 commented May 23, 2016

Well how should I say this. Thanks for the hard work until now but there is something bugging until now ther was no add support for USB flash drive wich in comparison to a SDHC Card have more storages space and chipper in the same time. It's not like i complain about not having it but having a lot of SD card is hard for me as the maximum storage space we have is 64go thanks for the time

@CreeperMario
Copy link

@bijita1 we cannot provide USB loading without access to an IOSU exploit. The system just doesn't allow it.

Also, this isn't the place to ask for something. Next time, please file an issue.

@bijita1
Copy link

bijita1 commented May 30, 2016

Thanks it was very helpful
On May 23, 2016 9:34 PM, "CreeperMario" [email protected] wrote:

@bijita1 https://github.com/bijita1 we cannot provide USB loading
without access to an IOSU exploit. The system just doesn't allow it.

Also, this isn't the place to ask for something. Next time, please file an
issue.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#68 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants