Fix glm::is_null epsilon test
#1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately it seems that the existing bound isn't sufficient to call |
CAD97
force-pushed
the
patch-4
branch
2 times, most recently
from
f6e9e8c
to
b37ae36
Compare
The existing implementation compares each component to zero with an epsilon; effectively `glm::all(glm::is_comp_null(v, epsilon))`. This probably isn't the desired semantics when calling `glm::is_null`; rather, we want to determine if the magnitude of the vector is within `epsilon` units of zero. It's the question of circle versus square. This behavior matches that of OpenGL Mathematics.
|
(Apologies for the force pushes; I initially wrote the patch in GitHub's UI without rustc to yell at me when I got things wrong. It should be fixed and squashed now.) |
|
Looks like this is correct; glm computes this for vectors differently than for matrices. Code change LGTM but I'll leave the semver-wrangling to someone with more experience. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation compares each component to zero with an epsilon; effectively
glm::all(glm::is_comp_null(v, epsilon)). This probably isn't the desired semantics when callingglm::is_null; rather, we want to determine if the magnitude of the vector is withinepsilonunits of zero. It's the question of circle versus square.The new behavior matches that of OpenGL Mathematics.