Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: iterator over rust range #43

Merged
merged 2 commits into from
Jul 15, 2024
Merged

feat: iterator over rust range #43

merged 2 commits into from
Jul 15, 2024

Conversation

dimastbk
Copy link
Owner

@dimastbk dimastbk commented Nov 29, 2023 •
edited
Loading

Memory usage:
Figure_1

  • red - openpyxl, read_only=True, iter_rows()
  • black - master, to_python()
  • blue - this PR, iter_rows()

example file (saved as xlsx in LibreOffice).

TODO:

  1. Fix empty cells and tests

@spumer
Copy link

spumer commented Jan 13, 2024

Any updates?

@alanxoc3
Copy link

alanxoc3 commented May 7, 2024

Thanks for putting together the PoC. This would be really cool to see available in the official package.

So.... I'm bumping this. Any updates?

@dimastbk dimastbk marked this pull request as ready for review July 15, 2024 09:52
@dimastbk dimastbk merged commit 8765389 into master Jul 15, 2024
28 checks passed
@dimastbk dimastbk deleted the issue42 branch July 15, 2024 09:54
@dimastbk dimastbk mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimastbk @spumer @alanxoc3