Rebuild c files using cython 0.29.37 #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nickbaum. I cherry-picked this commit into a new PR to get the failing github action to pass. Seems like it doesn't play nice with PRs from forks and I am unable to dig more into that at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only updates the c files using cython 0.29.37.
Currently tests fail for any pull requests unless you rebuild the c files, which makes for a much messier diff:
cython<1.0.0)This change does not update setup.py, nor make any other changes. Looking at Cython's changelog, the changes between 0.29.35 and 0.29.37 are only bug fixes, so this should be very low risk.
Blocking #219.