Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unittest to run tests #222

Merged
merged 10 commits into from
Sep 9, 2024
Merged

Use unittest to run tests #222

merged 10 commits into from
Sep 9, 2024

Conversation

gherceg
Copy link
Contributor

@gherceg gherceg commented Sep 4, 2024

General cleanup in addition to switching the test runner.

Copy link
Contributor

@millerdev millerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I assume you're still working on this since tests are failing.

tox.ini Outdated
@@ -1,7 +0,0 @@
[tox]
envlist = py37,py38,py39,py310,py311
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was testing against a bunch of different Python versions. Is that now done somewhere else?

Edit: looks like github actions is configured to do it, so should be safe to remove here, assuming this is not used elsewhere.

@gherceg gherceg merged commit 0bc25d8 into master Sep 9, 2024
7 checks passed
@gherceg gherceg deleted the gh/change-testrunner branch September 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants