Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not setup bdist #169

Merged
merged 2 commits into from
May 15, 2019
Merged

Do not setup bdist #169

merged 2 commits into from
May 15, 2019

Conversation

emord
Copy link
Contributor

@emord emord commented May 14, 2019

Found this while releasing a new version. I think this was left over from before we had cython, not sure why it wasn't caught till now

https://wheel.readthedocs.io/en/stable/user_guide.html

If your project contains no C extensions and is expected to work on both Python 2 and 3, you will want to tell wheel to produce universal wheels by adding this to your setup.cfg file:

We contain C extensions, so we shoudn't set this

@emord emord requested a review from nickpell May 14, 2019 14:06
@emord emord merged commit 2103164 into master May 15, 2019
@emord emord deleted the je/no-bdist branch May 15, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants