Avoid recursion when a model instance has multiple deferred audit fields #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deferred fields are loaded by calling 'refresh_from_db' which in turn calls the model init method. During init, we attempt to attach initial values for audited fields. If any of the audited fields are deferred, 'refresh_from_db' is called again.
snopoke
changed the title
millerdev
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deferred fields are loaded by calling 'refresh_from_db'
which in turn calls the model init method. During init, we attempt
to attach initial values for audited fields. If any of the
audited fields are deferred, 'refresh_from_db' is called
again.
This change decorates the
refresh_from_dbmethod on models to ensure thatall audited fields are present in the refresh.
An alternative approach to this would be to prevent deferred loading of audited fields in the first place however I'm not sure if that's always possible considering Django uses this internally in some instances e.g. collecting related deleted objects.
Relates to dimagi/open-chat-studio#186