Testing

.hermione.conf.js

@@ -0,0 +1,26 @@
+module.exports = {
+    baseUrl: 'http://localhost:3000',
+    compositeImage: true,
+
+    sets: {
+        desktop: {
+            files: 'hermione/test/desktop'
+        }
+    },
+
+    browsers: {
+        chrome: {
+            desiredCapabilities: {
+                browserName: 'chrome'
+            }
+        }
+    },
+
+    plugins: {
+        'html-reporter/hermione': {
+            path: 'hermione/html-report'
+        },
+        'hermione-expect-location': true,
+        'hermione-link-traversal': true
+    }
+};

README.md

@@ -31,3 +31,8 @@ npm start
 - нужно добавить в README список логических блоков системы и их сценариев
 - для каждого блока нужно написать модульные тесты
 - если необходимо, выполните рефакторинг, чтобы реорганизовать логические блоки или добавить точки расширения
+
+## Логические блоки системы
+1. Навигация — составление url и хлебных крошек. Методы `buildFolderUrl`, `buildFileUrl`, `buildBreadcrumbs`
+1. Гит — получение и обработка данных git. Методы: `gitHistory`, `gitFileTree`, `gitFileContent`
+1. Контроллеры — обработка и передча данных на view. Методы, экспортируемые из файлов в папке `controllers`

app.js

@@ -4,10 +4,23 @@ const express = require('express');
 const PORT = 3000;
 const HOST = '::';
 
+const {   
+  gitHistoryFactory,
+  gitFileTreeFactory,
+  gitFileContentFactory 
+} = require('./utils/git');
+
+const gitHistory = gitHistoryFactory();
+const gitFileTree = gitFileTreeFactory();
+const gitFileContent = gitFileContentFactory();
+
 // controllers
-const indexController = require('./controllers/indexController');
-const filesController = require('./controllers/filesController');
-const contentController = require('./controllers/contentController');
+const indexController = require('./controllers/indexController')();
+const filesController = require('./controllers/filesController')();
+const contentController = require('./controllers/contentController')({
+  gitFileTree,
+  gitFileContent
+});
 
 const app = express();
 

controllers/contentController.js

@@ -1,28 +1,29 @@
-const { gitFileContent, gitFileTree } = require('../utils/git');
 const { buildFolderUrl, buildBreadcrumbs } = require('../utils/navigation');
 
-module.exports = function(req, res, next) {
-  const { hash } = req.params;
-  const path = req.params[0].split('/').filter(Boolean);
+module.exports = function({ gitFileTree, gitFileContent }) {
+  return function(req, res, next) {
+    const { hash } = req.params;
+    const path = req.params[0].split('/').filter(Boolean);
 
-  gitFileTree(hash, path.join('/'))
-    .then(function([file]) {
-      if (file && file.type === 'blob') {
-        return gitFileContent(file.hash);
-      }
-    })
-    .then(
-      content => {
-        if (content) {
-          res.render('content', {
-            title: 'content',
-            breadcrumbs: buildBreadcrumbs(hash, path.join('/')),
-            content
-          });
-        } else {
-          next();
+    gitFileTree(hash, path.join('/'))
+      .then(function([file]) {
+        if (file && file.type === 'blob') {
+          return gitFileContent(file.hash);
         }
-      },
-      err => next(err)
-    );
+      })
+      .then(
+        content => {
+          if (content) {
+            res.render('content', {
+              title: 'content',
+              breadcrumbs: buildBreadcrumbs(hash, path.join('/')),
+              content
+            });
+          } else {
+            next();
+          }
+        },
+        err => next(err)
+      );
+  };
 };

controllers/filesController.js

@@ -1,10 +1,12 @@
-const { gitFileTree } = require('../utils/git');
+const { gitFileTreeFactory } = require('../utils/git');
 const {
   buildFolderUrl,
   buildFileUrl,
   buildBreadcrumbs
 } = require('../utils/navigation');
 
+const gitFileTree = gitFileTreeFactory();
+
 function buildObjectUrl(parentHash, { path, type }) {
   switch (type) {
     case 'tree':
@@ -16,26 +18,28 @@ function buildObjectUrl(parentHash, { path, type }) {
   }
 }
 
-module.exports = function(req, res, next) {
-  const { hash } = req.params;
-  const pathParam = (req.params[0] || '').split('/').filter(Boolean);
+module.exports = function(getFileTree = gitFileTree) {
+  return function(req, res, next) {
+    const { hash } = req.params;
+    const pathParam = (req.params[0] || '').split('/').filter(Boolean);
 
-  const path = pathParam.length ? pathParam.join('/') + '/' : '';
+    const path = pathParam.length ? pathParam.join('/') + '/' : '';
 
-  return gitFileTree(hash, path).then(
-    list => {
-      const files = list.map(item => ({
-        ...item,
-        href: buildObjectUrl(hash, item),
-        name: item.path.split('/').pop()
-      }));
+    return getFileTree(hash, path).then(
+      list => {
+        const files = list.map(item => ({
+          ...item,
+          href: buildObjectUrl(hash, item),
+          name: item.path.split('/').pop()
+        }));
 
-      res.render('files', {
-        title: 'files',
-        breadcrumbs: buildBreadcrumbs(hash, pathParam.join('/')),
-        files
-      });
-    },
-    err => next(err)
-  );
+        res.render('files', {
+          title: 'files',
+          breadcrumbs: buildBreadcrumbs(hash, pathParam.join('/')),
+          files
+        });
+      },
+      err => next(err)
+    );
+  };
 };

controllers/indexController.js

@@ -1,20 +1,24 @@
-const { gitHistory } = require('../utils/git');
+const { gitHistoryFactory } = require('../utils/git');
 const { buildFolderUrl, buildBreadcrumbs } = require('../utils/navigation');
 
-module.exports = function(req, res) {
-  gitHistory(1, 20).then(
-    history => {
-      const list = history.map(item => ({
-        ...item,
-        href: buildFolderUrl(item.hash, '')
-      }));
+const gitHistory = gitHistoryFactory();
 
-      res.render('index', {
-        title: 'history',
-        breadcrumbs: buildBreadcrumbs(),
-        list
-      });
-    },
-    err => next(err)
-  );
+module.exports = function(getHistory = gitHistory) {
+  return function(req, res) {
+    getHistory(1, 20).then(
+      history => {
+        const list = history.map(item => ({
+          ...item,
+          href: buildFolderUrl(item.hash, '')
+        }));
+
+        res.render('index', {
+          title: 'history',
+          breadcrumbs: buildBreadcrumbs(),
+          list
+        });
+      },
+      err => next(err)
+    );
+  };
 };

hermione/html-report/index.html

@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+<head>
+<title>HTML report</title>
+<meta charset="utf-8">
+<link href="report.min.css" rel="stylesheet"></head>
+<body class="report">
+    <div id="app"></div>
+<script type="text/javascript" src="data.js"></script><script type="text/javascript" src="report.min.js"></script></body>
+</html>

hermione/plugins/hermione-expect-location/index.js

@@ -0,0 +1,13 @@
+const expect = require('chai').expect;
+
+module.exports =  function expectLocation(hermione, opts) {
+  hermione.on(hermione.events.NEW_BROWSER, (browser) => {
+    browser.addCommand('expectLocation', (selector, expected) => {
+      return browser.getLocation(selector)
+              .then(location => {
+                expect(location).to.deep.equal(expected);
+              });
+    });
+  });
+};
+

hermione/plugins/hermione-expect-location/package.json

@@ -0,0 +1,11 @@
+{
+  "name": "hermione-expect-location",
+  "version": "1.0.0",
+  "description": "",
+  "main": "index.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "author": "",
+  "license": "ISC"
+}

hermione/plugins/hermione-link-traversal/index.js

@@ -0,0 +1,16 @@
+const expect = require('chai').expect;
+
+module.exports =  function traverseLink(hermione, opts) {
+  hermione.on(hermione.events.NEW_BROWSER, (browser) => {
+    browser.addCommand('traverseLink', (params) => {
+      return browser.url(params.fromUrl)
+              .click(params.linkEl)
+              .waitForExist(params.waitForEl)
+              .getUrl()
+              .then(url => {
+                expect(url).to.equal(`${hermione.config.baseUrl}${params.toUrl}`);
+              });
+    });
+  });
+};
+

hermione/plugins/hermione-link-traversal/package.json

@@ -0,0 +1,11 @@
+{
+  "name": "hermione-link-traversal",
+  "version": "1.0.0",
+  "description": "",
+  "main": "index.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "author": "",
+  "license": "ISC"
+}

hermione/test/desktop/file.hermione.js

@@ -0,0 +1,30 @@
+const expect = require('chai').expect;
+const pageUrl = '/content/999bfb1ec309158f4c86edee76fa5630a3aba565/README.md';
+
+describe('File', function() {
+  describe('screenshot testing', function() {
+    it('has breadcrumbs', function() {
+        return this.browser
+            .url(pageUrl)
+            .assertView('breadcrumbs', '.breadcrumbs');
+    });
+
+    it('has file tree', function() {
+        return this.browser
+          .url(pageUrl)
+          .assertView('file content', '.content');
+    });
+  });
+
+  describe('position', function() {
+    it('renders breadcrumbs in proper location', function() {
+      return this.browser.url(pageUrl)
+        .expectLocation('.breadcrumbs', { x: 200, y: 28 });
+    });
+
+    it('renders file content in proper location', function() {
+      return this.browser.url(pageUrl)
+        .expectLocation('.content', { x: 200, y: 88 });
+    });
+  });
+});

hermione/test/desktop/filesystem.hermione.js

@@ -0,0 +1,30 @@
+const expect = require('chai').expect;
+const pageUrl = '/files/999bfb1ec309158f4c86edee76fa5630a3aba565/';
+
+describe('Files', function() {
+  describe('screenshot testing', function() {
+    it('has breadcrumbs', function() {
+        return this.browser
+            .url(pageUrl)
+            .assertView('breadcrumbs', '.breadcrumbs');
+    });
+
+    it('has file tree', function() {
+        return this.browser
+          .url(pageUrl)
+          .assertView('file tree', '.content');
+    });
+  });
+
+  describe('position', function() {
+    it('renders breadcrumbs in proper location', function() {
+      return this.browser.url(pageUrl)
+        .expectLocation('.breadcrumbs', { x: 200, y: 28 });
+    });
+
+    it('renders file tree in proper location', function() {
+      return this.browser.url(pageUrl)
+        .expectLocation('.content', { x: 200, y: 88 });
+    });
+  });
+});