Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more markdown images to gallery when lightgallery is enabled #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evilpan
Copy link

@evilpan evilpan commented Sep 19, 2020

This address issues like #213 #238 #490 and others, which will enable lightgallery for most images in markdown document.

Enabled for image that has Text or/and Title:

![text](https://exapmle.com/image.png)
![](https://exapmle.com/image.png "title")
![text](https://exapmle.com/image.png "title")

Disable for image with neither Text not Title:

![](https://exapmle.com/image.png)

showcase: https://evilpan.com/2014/12/12/markdown-test/#%E5%9B%BE%E7%89%87

@uPagge
Copy link

uPagge commented Dec 1, 2020

Thank you very much for this, sorry the developer does not approve of this change

@uPagge
Copy link

uPagge commented Dec 1, 2020

I also suggest adding <a target="_blank" in the image.html file... so that the images open in a new window without a gallery, so as not to close the article

@nekr0z
Copy link
Contributor

nekr0z commented Dec 1, 2020

I also suggest adding <a target="_blank" in the image.html file... so that the images open in a new window without a gallery, so as not to close the article

Forcing a new tab/window is a bad practice and should not be used without a very strong reason. The default should be assuming that the visitor knows what he/she wants and knows to middle-click when indeed desiring for the image to open in a new tab.

@uPagge
Copy link

uPagge commented Dec 2, 2020

hmm, maybe you are right

@uPagge
Copy link

uPagge commented Dec 6, 2020

This change I moved to the new fork 😄

Since the developer has unfortunately abandoned the project 😞, I would like to take responsibility for its support and development in the future.

🔗 -> https://github.com/uPagge/uBlogger.

I focused on adding new features, refreshed the design of the posts, fixed the bugs I found.
There were so many changes (the ability to choose a separate design for the post, breadcrumbs, a new comment system and much more), and so much to do, that I decided to give the template a new name uBlogger.

Short and basic, what I have changed

I will be glad if you look at it, you may like the updated design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants