Fix manifest URL missing base

[j-maas]

No description provided.

[dillonkearns]

Thank you for the PR @j-maas!

It would be nice to get a test around this to make sure this continues to work in the future. Maybe we can add another diff test similar to the escaping example.

The way that test works is it just runs git diff --exit-code so it will give an error exit status if there are uncommitted changes. That way the committed dist output acts as an approved output that cannot change without re-approval.

The script is like this: https://github.com/j-maas/elm-pages/blob/863e0318a876a5b2166d28543b1de5561f40a544/examples/escaping/package.json#L7. If that sounds good, we can

• Copy the examples/escaping directory
• Use a --base flag in the package.json script for the new diff test
• Run another diff test by copying the setup here: https://github.com/j-maas/elm-pages/blob/863e0318a876a5b2166d28543b1de5561f40a544/.github/workflows/ci.yml#L56-L57
• Change the project to remove escaping-specific test cases and just use a simple test case

[j-maas]

Awesome test setup!

I noticed that you have tried to un-gitignore the .html files (https://github.com/dillonkearns/elm-pages/blob/master/examples/escaping/.gitignore#L4). It seems that this has not the desired effect.¹ Instead, when you force-commit files, changes to them will actually be picked up without needing to add any rule to the .gitignore.

Is that something that you want me to apply to the other examples as well? That is, remove the obsolete .gitignore rule there?

Footnotes

1. "It is not possible to re-include a file if a parent directory of that file is excluded." https://git-scm.com/docs/gitignore ↩

[j-maas]

Adding this example also demonstrates the issue that #234 solves: The index page is not rendered correctly.

[dillonkearns]

@j-maas is this something that is fixed by #236?

[j-maas]

Oh, yes! Didn't even notice it. 😅

[dillonkearns]

Thanks so much @j-maas! 🙏

[j-maas]

Thank you for helping me out with this! 😊