Handle missing trailing slashes in dev server #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @y0hy0h, thanks for the PR. I tried this out but was unsure how to test it. Could you share some steps to reproduce the issue so I can compare the before-after? |
|
Sure! I've added some steps to the description. |
|
I found a simpler way to fix and an additional issue with #234. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when using for example
elm-pages dev --base sub, the dev server would correctly rewritelocalhost:1234/sub/, but notlocalhost:1234/sub(missing trailing slash).This PR makes the dev server agnostic towards trailing slashes.
Reproduction of the issue
npm start -- --base sub