This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
Add new Color Values #58
Open
chrisdw
wants to merge
9
commits into
dillenmeister:master
Choose a base branch
from
chrisdw:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the new color values for Pink, Sky, Lime and Black
Worked for me, thanks! |
As colors are moving to being arbitary a fixed list in an enum won't work, here so change to a string based dictionary.
Works for me too |
Not sure what's up with the webhook test, all the other failures appear to be due to changes in the test board used by the tests. |
Does this affect this PR? |
More than likely, if you can create whatever labels you like then that field will have to become a string rather than an Enum. |
Repoint the test at a board I control and get the test green Boards no longer have a description and the pinned property is deprecated. The starred property replaces it. Fix some bugs in action data
Fix code and interface to cope with the fact that the Checklist API has changed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new color values for Pink, Sky, Lime and Black