New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Array.isArray, isObject from lodash, Buffer.isBuffer #1

Open

yrambler2001 wants to merge 2 commits into diia-open-source:main from yrambler2001:patch-1

yrambler2001 commented Mar 13, 2024

Array.isArray exists more than 10 years.

There is no need to use value && typeof value === 'object' && value.constructor === Array

yrambler2001 added 2 commits

March 13, 2024 22:11


          use Array.isArray

ce8c9e8


          use common type checking

1b6e5f5

yrambler2001 changed the title ~~use Array.isArray~~ use Array.isArray, isObject from lodash, Buffer.isBuffer

Author

yrambler2001 commented Mar 13, 2024 •

edited

Loading

it is common in diia repositories to use isObject from lodash
https://github.com/diia-open-source/be-diia-logger/blob/c26c7ce94c594a009c6bd99ec660304f996d248e/src/index.ts#L4
https://github.com/diia-open-source/be-diia-logger/blob/c26c7ce94c594a009c6bd99ec660304f996d248e/src/index.ts#L42

Array.isArray
https://github.com/diia-open-source/be-diia-logger/blob/c26c7ce94c594a009c6bd99ec660304f996d248e/src/trimmer.ts#L32

and Buffer.isBuffer
https://github.com/diia-open-source/be-diia-logger/blob/c26c7ce94c594a009c6bd99ec660304f996d248e/src/trimmer.ts#L28

tshemsedinov commented Mar 15, 2024

Please add permalinks to code like in this issue: diia-open-source/be-user-service#92 or at least urls to certain files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet